fix strict eq effect test#1170
Merged
rmorshea merged 1 commit intoreactive-python:mainfrom Dec 10, 2023
Merged
Conversation
rmorshea
force-pushed
the
fix-strict-eq-effect-test
branch
from
5edfe26 to
2e80a07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request you agree that all contributions to this project are made under the MIT license.
Issues
The test was clearly intended to be parametrized but it wasn't using it.
Solution
Use it a la the test just prior for use_state
Checklist
changelog.rsthas been updated with any significant changes.